Fix Android double-tap not working.

[madmiraal]

#37158 added the event's button state to Android's onDoubleTap gesture processing. However, the button state is always zero. This broke double tapping (#8151, #46100, #46101).

As per the documentation, the onDoubleTap notification is "Triggered on the down event of second tap." Furthermore, since double-clicks are only detected on the left mouse button, even if the button state was correct, we can safely assume that the event pressed parameter will be true, button_index will be MouseButton::LEFT and button_mask will be MASK_LEFT.

Therefore this PR reverts #37158's addition of the button state to the Android onDoubleTap gesture processing.

Fixes #8151.
Provides a partial fix for #46100 and #46101 in as much as the output on Android will be

Event doubleclick = False, pressed = True, button_index = 1
Event doubleclick = False, pressed = False, button_index = 1
Event doubleclick = True, pressed = True, button_index = 1
Event doubleclick = False, pressed = True, button_index = 1
Event doubleclick = False, pressed = False, button_index = 1

vs the desktop output of:

Event doubleclick = False, pressed = True, button_index = 1
Event doubleclick = False, pressed = False, button_index = 1
Event doubleclick = True, pressed = True, button_index = 1
Event doubleclick = False, pressed = False, button_index = 1

In other words there is still an extra event, but at least there is a correct doubleclick event that can be detected appropriately.

[thebestnom]

Right click can also generate double click (tested 2 years ago on non stock rom 😅) need to account for that

[madmiraal]

I'm not sure supporting a right-button double-click that requires a "non stock rom" to even be triggered is needed. Looking at the comments from #37158 (e.g. #37158 (comment) and #37158 (comment)) it appears as if you agree. Is a right-button double click needed for anything?

That been said, to get this to work properly (and properly fix #46100 and #46101) would require separating out the mouse double-clicks from the double-taps. I'm working on a PR to achieve that. In the meantime this PR provides a fix for the regression introduced by #37158.

[Calinou]

Does this PR supersede #54225?

[madmiraal]

Does this PR supersede #54225?

Yes.

[m4gr3d]

@madmiraal Looks good; just need to be rebased prior to merging.

[m4gr3d]

@madmiraal Nevermind the previous review.

I've tested the current logic on a stock Android 12 on a Pixel 5, and despite what the documentation states, double clicks from a connected bluetooth mouse is also handled by the GestureHandler.

It looks like the proper solution would be #54225 instead.

[madmiraal]

I've tested the current logic on a stock Android 12 on a Pixel 5, and despite what the documentation states, double clicks from a connected bluetooth mouse is also handled by the GestureHandler.

This PR doesn't prevent double-clicks from working. It just assumes all double-clicks are left mouse button clicks.

[m4gr3d]

Superseded by #65434

[madmiraal]

I think it's a bit presumptuous to close this issue before #65434 has been approved and merged.