Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] SpaceBullet::recover_from_penetration: skip compound shapes without child shapes #59864

Merged

Conversation

rburing
Copy link
Member

@rburing rburing commented Apr 4, 2022

Before, this case would incorrectly be treated as an error, causing an early return, in particular skipping other possibly relevant shapes.

Fixes #59826 (which involves a GridMap without any collision shapes, causing depenetration from the floor to be skipped)

…hild shapes

Before, this case would incorrectly get caught as an error, causing an
early return, in particular skipping other possibly relevant shapes.
@rburing rburing requested a review from a team as a code owner April 4, 2022 09:17
@akien-mga akien-mga added this to the 3.5 milestone Apr 4, 2022
@akien-mga akien-mga merged commit 288dbe4 into godotengine:3.x Apr 29, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants