Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android Editor default display scale #59866

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Apr 4, 2022

Updates the editor display scale based on the device's scaled density.

@m4gr3d m4gr3d added this to the 4.0 milestone Apr 4, 2022
@m4gr3d m4gr3d requested a review from a team as a code owner April 4, 2022 11:11
@m4gr3d m4gr3d force-pushed the update_default_display_scale_main branch from 9b1dd07 to e4d5913 Compare April 4, 2022 11:19
@Calinou
Copy link
Member

Calinou commented Apr 4, 2022

I'm worried that on Android, the device's pixel density can be very high (3 or 4). This causes the editor to be at an unusable size by default on phones (the inspector will be cut off). On both devices I've tried (OnePlus 6 and Samsung Galaxy Fold 2), 2.0 was the optimal scale in terms of usability without having too many things cut off.

The automatically used editor scale value within should probably be capped at 2.0 by default.

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Apr 4, 2022

I'm worried that on Android, the device's pixel density can be very high (3 or 4). This causes the editor to be at an unusable size by default on phones (the inspector will be cut off). On both devices I've tried (OnePlus 6 and Samsung Galaxy Fold 2), 2.0 was the optimal scale in terms of usability without having too many things cut off.

The automatically used editor scale value within should probably be capped at 2.0 by default.

@Calinou 2.0 was the optimal scale because that's the actual density for the Fold 2 :)

I tested on several devices (emulator & actual phone) and using the scaled density is a good rule of thumb. For example, on a pixel 3 xl, 2.0 is too small, but 3.0 is just right, which is also the device's scaled density :)

Given we're still in alpha, let's go with the scaled density approach. We can revise (or cap it) if we receive issues and reports that it's unusable on certain devices.

@m4gr3d m4gr3d force-pushed the update_default_display_scale_main branch from e4d5913 to 8eabf77 Compare April 4, 2022 16:24
@akien-mga akien-mga merged commit 53317bb into godotengine:master Apr 4, 2022
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the update_default_display_scale_main branch April 4, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants