Fix some issues found by cppcheck. #59911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
changed the title
akien-mga
reviewed
Apr 5, 2022
| @@ -51,7 +51,7 @@ ScriptIterator::ScriptIterator(const String &p_string, int p_start, int p_length | |||
| } | |||
|
|
|||
| int paren_size = PAREN_STACK_DEPTH; | |||
| ParenStackEntry *paren_stack = (ParenStackEntry *)memalloc(paren_size * sizeof(ParenStackEntry)); | |||
| ParenStackEntry *paren_stack = static_cast<ParenStackEntry *>(memalloc(paren_size * sizeof(ParenStackEntry))); | |||
There was a problem hiding this comment.
For the record, what are the kind of issues with using a C-style cast instead of static_cast or dynamic_cast in this context that cppcheck would report?
There was a problem hiding this comment.
cppcheck reports all C-casts, I guess the only purpose of these reports is to make intention of the cast more clear, so it's just a style change.
bruvzg
force-pushed
the
cppcheck_fixes
branch
4 times, most recently
from
dc98130 to
3620e92
Compare
|
Looked at the rest of report, and added more fixes (but it's definitely not everything):
|
bruvzg
changed the title
akien-mga
reviewed
Apr 6, 2022
akien-mga
reviewed
Apr 6, 2022
akien-mga
approved these changes
Apr 6, 2022
|
Thanks! |
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues found by https://calinou.github.io/godot-cppcheck/master/