Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shaped_text_get_word_breaks() #60102

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Improve shaped_text_get_word_breaks() #60102

merged 1 commit into from
Apr 11, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 10, 2022

Inspired by #55228

  • adds missing default arguments to the method
  • improves documentation

Closes #55228 (but the actual error the issue mentions was already fixed)

@KoBeWi KoBeWi added this to the 4.0 milestone Apr 10, 2022
@KoBeWi KoBeWi requested review from a team as code owners April 10, 2022 15:40
bruvzg
bruvzg requested changes Apr 10, 2022
View reviewed changes
doc/classes/TextServer.xml Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 9528aa4 into godotengine:master Apr 11, 2022
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the graphememe branch April 11, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Assign a string to custom_punctuation property of a TextParagraph returns error message.
3 participants
@KoBeWi @akien-mga @bruvzg