Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows Export] Improve error messages for missing rcedit and signtool. #60579

Merged
merged 1 commit into from
Apr 28, 2022
Merged

[Windows Export] Improve error messages for missing rcedit and signtool. #60579

merged 1 commit into from
Apr 28, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Apr 28, 2022

Follow up to #56093, fix rcedit fallback to the PATH that was missed during rebase, and improve error messages for missing rcedit and signtool.

@bruvzg bruvzg added this to the 4.0 milestone Apr 28, 2022
@bruvzg bruvzg requested a review from a team as a code owner April 28, 2022 07:51
@bruvzg bruvzg mentioned this pull request Apr 28, 2022
Merged
@akien-mga akien-mga merged commit d01e412 into godotengine:master Apr 28, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the export_err_msgs branch April 28, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:windows topic:export
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga