Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Basis get_axis to get_column, remove redundant methods #60727

Merged
merged 1 commit into from
May 3, 2022
Merged

Rename Basis get_axis to get_column, remove redundant methods #60727

merged 1 commit into from
May 3, 2022

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented May 3, 2022 •
edited
Loading

This is a follow-up to #60627 that was requested by @reduz when discussing it.

  • Basis: Unify get_axis and get_column to get_column (they do the same thing)
  • Basis: Unify set_axis and set_column to set_column (they do the same thing)
  • Basis: Rename set to set_columns
  • Basis: Remove get_row and set_row since it's not needed now that elements was renamed to rows
  • Transform2D: Remove get_axis (get_column) since it's not needed now that elements was renamed to columns

@aaronfranke aaronfranke added this to the 4.0 milestone May 3, 2022
@aaronfranke aaronfranke requested review from a team as code owners May 3, 2022 13:24
akien-mga
akien-mga approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in PR review meeting. The p_axis arguments can be renamed to p_index, and get_row could be removed as rows is exposed as a property.

@aaronfranke aaronfranke requested a review from a team as a code owner May 3, 2022 13:37
@aaronfranke aaronfranke changed the title Rename Basis and Transform2D get_axis to get_column Rename Basis get_axis to get_column, remove redundant methods May 3, 2022
@aaronfranke aaronfranke requested a review from akien-mga May 3, 2022 14:35
@akien-mga akien-mga merged commit 1b29927 into godotengine:master May 3, 2022
@akien-mga
Copy link
Member

Thanks!

@aaronfranke aaronfranke deleted the basis-axis-column branch May 3, 2022 17:36
@aaronfranke aaronfranke mentioned this pull request May 3, 2022
Closed
@raulsntos raulsntos mentioned this pull request Jan 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronfranke @akien-mga