Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rotation unit tests for Transform3D #61013

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add rotation unit tests for Transform3D #61013

merged 1 commit into from
Apr 19, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 13, 2022

Follow-up to #61008. This salvages #43694.

Thanks @AlexanderPruss for the original PR 🙂

@Calinou Calinou requested a review from a team as a code owner May 13, 2022 21:52
@Calinou Calinou added this to the 4.0 milestone May 13, 2022
@Calinou Calinou mentioned this pull request May 13, 2022
Closed
@Calinou Calinou force-pushed the test-add-transform3d branch from 91ded20 to bf29f25 Compare May 13, 2022 22:10
aaronfranke
aaronfranke requested changes May 13, 2022
View reviewed changes
tests/core/math/test_transform_3d.h Outdated Show resolved Hide resolved
@Geometror
Copy link
Member

There were some rudimentary test cases added for Transform3D with #55923. There might be some overlap, but I think this can be salvaged.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 10, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.x Jun 14, 2023
@Calinou @AlexanderPruss
Add rotation unit tests for Transform3D
4e6de25 
Co-authored-by: Alexander Pruss <alex.pruss@gmail.com>
@Calinou Calinou changed the title Add a partial test suite for Transform3D Add rotation unit tests for Transform3D Apr 10, 2024
@Calinou Calinou force-pushed the test-add-transform3d branch from bf29f25 to 4e6de25 Compare April 10, 2024 20:27
@Calinou Calinou requested a review from aaronfranke April 18, 2024 22:48
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 18, 2024
@akien-mga akien-mga merged commit 0f7452f into godotengine:master Apr 19, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the test-add-transform3d branch April 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleonc kleonc kleonc approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
enhancement topic:tests
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@Calinou @Geometror @akien-mga @aaronfranke @kleonc @YuriSizov