Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: do not pass custom click to item edited #61434

Merged
merged 1 commit into from
May 26, 2022

Conversation

nathanfranke
Copy link
Contributor

CC @trollodel, see #47665

This was preventing the item_edited signal from being called on Tree (broke editor features).

@nathanfranke nathanfranke requested a review from a team as a code owner May 26, 2022 08:26
@nathanfranke nathanfranke changed the title do not pass custom click to item edited tree: do not pass custom click to item edited May 26, 2022
@trollodel
Copy link
Contributor

The custom_item_clicked signal doesn't seem to be used by the editor, so it should be safe to emit both signals for now, while mantaining the mouse parameter where used.

(broke editor features)

Just to be sure, what brokes specifically?

@nathanfranke
Copy link
Contributor Author

(broke editor features)

Just to be sure, what brokes specifically?

My bad, I mean it broke the Editor->Editor Features dialog. Disabling editor features does not save or update, since the dialog relies on the item_edited signal.

Copy link
Contributor

@trollodel trollodel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be safe for the editor because the signal doesn't seems to be used by the editor and even if it's used, any connection must return if the signal is not triggered by the right mouse button.

@KoBeWi KoBeWi added this to the 4.0 milestone May 26, 2022
@akien-mga akien-mga merged commit 2e88628 into godotengine:master May 26, 2022
@akien-mga
Copy link
Member

Thanks!

@nathanfranke nathanfranke deleted the tree-item-edited branch May 26, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants