[3.x] Improve architectures in OS::has_feature and make it work on MSVC #61740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #61732 except it doesn't change the behavior of the existing
x86andarmdefines (in 3.x and in this PR, they will only be true for 32-bit).Note: wasm64 is for future-proofing, it doesn't exist yet even in master. Inevitably it will come eventually. I don't know if wasm64 support will be backported to 3.x when it does come to master, but it doesn't hurt to leave this code in here.
3.4 backport (assuming we want to backport further): https://github.com/aaronfranke/godot/tree/3.4-arch-os-feature