Fix GridMap Navigation transform changes and debug #61800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
navigation_gridmap_transform_debug_4.x
branch
from
1e17b28
to
b2bf0d6
Compare
smix8
changed the title
Fix GridMap navigation transforms and debug.
smix8
force-pushed
the
navigation_gridmap_transform_debug_4.x
branch
from
b2bf0d6
to
cb8d95c
Compare
akien-mga
added
the
cherrypick:3.x
akien-mga
approved these changes
Jun 8, 2022
|
Thanks! |
|
|
akien-mga
removed
the
cherrypick:3.x
Undone, there's no bake_navigation in 3.x and overall this looks like something worth a proper backport PR and testing. |
akien-mga
added
the
cherrypick:3.x
|
@smix8 BTW are you on the Godot Contributors Chat? Would be convenient to discuss navigation fixes/roadmap for 3.5+. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GridMap navigation transforms and debug.
GridMap did not update the transforms of navigation regions if the GridMap Node was moved.
GridMap with baked NavigationMesh did not create visuals for navigation debug at all.
GridMap clear() function was stuck in an RID delete loop with error spam from NavigationServer.
Part of #61293 and proposal #4507
Fixes #32244
Fixes #27216
Fixes #17118 since the doc is already merged now.