-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made hidden ProjectSettings groups more explicit #61818
Conversation
0b640b0
to
d36ebae
Compare
d36ebae
to
a2700ee
Compare
Rebased. I moved the prefix definition to their respective part of code. I also changed the prefix container from List to LocalVector, which I think is faster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me.
Note that this doesn't change the editor UI in any way, even when Advanced Settings is enabled.
It appears to add a lot of extra data to the docs, something broken in the implementation? |
a2700ee
to
2cd63a1
Compare
Fixed, I had to move This is a funny problem. InputMap is created before ProjectSettings, so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner.
Thanks! |
Follow-up to #61751
Changes long
if
into a more clean list of prefixes.I experimented with autoloads. At first I tried marking them as internal when added, but the problem is that this isn't saved. The properties are simply loaded with ProjectSettings resource and then re-flagged. So there is no avoiding
_get_property_list()
or_validate_property()
without some bigger changes that just aren't worth it.