Tweak default crash handler message in exported projects

[Calinou]

Follow-up to #61906.

When an exported project crashes, the crash handler message shouldn't reference the Godot issue tracker, as not all crashes are Godot's fault.

Reporting crashes that only occur on exported projects is still allowed, but it should not be done by people who aren't working on the project in question. This is especially true if we make crash logs more accessible, such as with #61906.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.5.

[akien-mga]

As you saw in #63839, this doesn't work as expected when the game crashes. The editor feature is only defined for the editor process, not for running the game from the editor / from the command line with a tools build.

[Calinou]

The editor feature is only defined for the editor process

I'm pretty sure the editor feature is supposed to be true for any editor build (that's what the documentation states too). Otherwise, Engine::is_editor_hint() should be used.

[akien-mga]

The editor feature is only defined for the editor process

I'm pretty sure the editor feature is supposed to be true for any editor build (that's what the documentation states too). Otherwise, Engine::is_editor_hint() should be used.

You're right:

#ifdef TOOLS_ENABLED
        if (p_feature == "editor") {
                return true;
        }
#else
        if (p_feature == "standalone") {
                return true;
        }
#endif

[Calinou]

My guess is that the feature tag can't be read by the crash handler. As a workaround, I was thinking we should change the default value of the setting using #ifdef TOOLS_ENABLED instead of relying on the editor feature tag to override the default.

We could also use the generic crash handler message in editor builds. I think people will figure out that they can report editor crash backtraces 🙂

[RedMser]

I encountered this problem in #64014 as well. Seems like the project settings' feature overrides are intentionally disabled in the editor.

[akien-mga]

I encountered this problem in #64014 as well. Seems like the project settings' feature overrides are intentionally disabled in the editor.

I opened this issue to keep track of this: #64100.