-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make enum/constant binds 64-bit. #61991
Conversation
bruvzg
commented
Jun 13, 2022
•
edited
Loading
edited
- Changes constant / enum data type to be 64-bit int.
6c2f47d
to
ec6a42b
Compare
I assume the 64bit change is due to running out of space for constants? |
Yes, but it's probably good it bump it to 64-bit anyway, since the rest of the integers are 64-bit. |
I see why this is needed, and this kind of visibility is needed for more than just fonts on labels. Many controls, containers especially, have very important properties hidden in overrides. But I'm not sure if this is a good way to do it. First of all, it's not clear to the user that it's a duplicated property. So they may get confused why there are two ways to set something very similar. The only clue would be that the tooltip should show it as Granted, these are existing problems with overrides as well, but as long as they are treated as a special case, it's less severe. Here they would be mixed with the normal properties, and those usability nuances get front and center. Second, this makes it less obvious for some properties that they are controlled by themes. I specifically renamed the So overall, I'm not sure. The way theme properties are presented in the inspector does not respect the inheritance chain, and doesn't respect the importance of those properties for each control. I'm kind of of a mind that there should be another "theme/configuration" tab, or something. But then again, reduz wants to move signals and groups into the inspector instead of having individual tabs, so this kind of solution wouldn't be welcome. I don't have a better idea at the moment. |
ec6a42b
to
860e246
Compare
Superseded by #62139, but make enums / constants 64-bit might be still useful, so keeping it for this purpose only. |
Thanks! |