Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline Navigation layer function names. #62052

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Jun 14, 2022

Streamline Navigation layer function names to set_navigation_layers and get_navigation_layers and all variables and parameters to navigation_layers as already done for the 3.5 navigation backport #61996.

The navigation layer functions used 2-3 different name and variable versions to great confusion. Especially such generic names as "set_layer" need to go yesterday as they always turn into a problem both in documentation and conversations as well as when new layer types are added.

@smix8 smix8 requested review from a team as code owners June 14, 2022 21:44
@smix8 smix8 force-pushed the navigation_layer_functions_4.x branch 3 times, most recently from 4cd345c to 4a90dc5 Compare June 14, 2022 22:01
Streamline Navigation layer function names.
@smix8 smix8 force-pushed the navigation_layer_functions_4.x branch from 4a90dc5 to 245da15 Compare June 14, 2022 22:18
@KoBeWi KoBeWi added this to the 4.0 milestone Jun 14, 2022
@akien-mga akien-mga merged commit 4f9c46d into godotengine:master Jun 14, 2022
@akien-mga
Copy link
Member

Thanks!

@smix8 smix8 deleted the navigation_layer_functions_4.x branch June 14, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants