Implement varargs in Methodinfo #62342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 23, 2022
akien-mga
approved these changes
Jun 23, 2022
Variadic templates are an awful thing. Implements godotengine#62233 using them in MethodInfo so less changes are required.
reduz
force-pushed
the
methodinfo-varargs
branch
from
d533c03 to
dd8c052
Compare
|
Damn, not having much luck with the sanitizer, I know what I am doing is perfectly safe but I kind of understand why the sanitizer does not like it. May need to switch a page based approach if I can't solve it. |
I guess you meant to post this on #62303, I don't see a sanitizer issue in this PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variadic templates are an awful thing. Implements #62233 using them in MethodInfo so less changes are required.