Fix light intensity and attenuation import from GLTF #62747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved the workflow. |
|
Note that lights with energy set to 0 are still rendered by Godot, so they will incur a performance cost. If this is not desired, the light should have its |
fire
approved these changes
Jul 5, 2022
akien-mga
added
the
cherrypick:3.x
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
I assume this fixes #54596 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing a GLTF scene, Omni and Spot lights calculated an Attenuation factor that could be set to infinity when the Intensity was 0. Also the intensity was never directly stored.
As discussed in rocket-chat, the Attenuation is used for artistic control, so lets just default it to 1 and use the Intensity properly instead.
Please note, the user can still set the attenuation to a big value and generate infinities in this line of the light shader, so a proper range should be added too somehow. I think PROPERTY_HINT_EXP_EASING here can't have a min and max, so maybe we can change it to PROPERTY_HINT_RANGE?
Noticed after loading the new Sponza scene where lights are stored with intensity 0:
Before (intensity = 1, attenuation = inf)
After (intensity = 0, attenuation = 1)
