Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x][GDNative] Expose String::join() over to GDNative Core API v1.3 #63073

Merged
merged 1 commit into from
Jul 16, 2022

Conversation

kdiduk
Copy link
Contributor

@kdiduk kdiduk commented Jul 16, 2022

Expose method join of the class String to GDNative.

This method was already implemented before and it was exposed to GDScript in the PR #56369.

In this PR it's just exposed over to GDNative Core API v1.3.

This PR is logically related to #55826. The proposal for this specific change was discussed here

@kdiduk kdiduk requested a review from a team as a code owner July 16, 2022 14:40
@Chaosus Chaosus added this to the 3.x milestone Jul 16, 2022
@akien-mga akien-mga modified the milestones: 3.x, 3.5 Jul 16, 2022
@akien-mga akien-mga merged commit e8e040a into godotengine:3.x Jul 16, 2022
@akien-mga
Copy link
Member

Thanks!

@kdiduk kdiduk deleted the gdnative-string-join branch July 16, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants