Fix: InputEventJoypadMotion should trigger only once on a vslider #63168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It could also be backported to 3.x. Was tested on both 4.0, 3.4 and 3.5 |
akien-mga
added
the
cherrypick:3.x
Levrault
force-pushed
the
master
branch
2 times, most recently
from
43df020
to
a720e51
Compare
|
PR has been updated to match my proposal godotengine/godot-proposals#4911 |
KoBeWi
reviewed
Apr 18, 2023
KoBeWi
reviewed
Apr 18, 2023
KoBeWi
reviewed
Apr 18, 2023
KoBeWi
reviewed
Apr 18, 2023
KoBeWi
reviewed
Apr 18, 2023
KoBeWi
reviewed
Apr 18, 2023
KoBeWi
reviewed
Apr 18, 2023
|
Seems fine, but I left some comments. The comments I left in PopupMenu also apply to Slider (mostly). |
|
@KoBeWi The same jitter seems to happen when using the keyboard :/ it seems left visible since it's a little bit faster the gamepad Peek.2023-04-19.10-00.mp4 |
|
Then I guess it's fine. |
KoBeWi
reviewed
Apr 19, 2023
KoBeWi
reviewed
Apr 19, 2023
KoBeWi
reviewed
Apr 19, 2023
KoBeWi
reviewed
Apr 19, 2023
KoBeWi
reviewed
Apr 20, 2023
KoBeWi
approved these changes
Apr 20, 2023
gaheldev
added a commit
to bear-minimum-studio/nightbear
that referenced
this pull request
May 20, 2023
not properly supported by godot yet godotengine/godot#63168 should fix it soon
|
@KoBeWi sorry, I didn't saw your comment. Commit are squashed now. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62932
Closes godotengine/godot-proposals#4911
Both slider and popup_menu has been modified to support joypad motion.
2023-02-09.13-10-43.mp4