Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CanvasItem not exiting its canvas group on canvas exit #63235

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Fix CanvasItem not exiting its canvas group on canvas exit #63235

merged 1 commit into from
Jul 20, 2022

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Jul 20, 2022

master version of #63234.

Fixes #63183.

@kleonc kleonc added this to the 4.0 milestone Jul 20, 2022
@kleonc kleonc requested a review from a team as a code owner July 20, 2022 10:48
@kleonc kleonc changed the title Fix CanvasItem not existing its canvas group on canvas exit Fix CanvasItem not exiting its canvas group on canvas exit Jul 20, 2022
@kleonc kleonc force-pushed the canvas-item-remove-from-canvas-group branch from 09d81ce to 854bfea Compare July 20, 2022 10:51
@akien-mga
Copy link
Member

Needs a rebase to fix CI build (temporary error).

@kleonc kleonc force-pushed the canvas-item-remove-from-canvas-group branch from 854bfea to 57ff403 Compare July 20, 2022 19:35
@akien-mga akien-mga merged commit 976cb7e into godotengine:master Jul 20, 2022
@akien-mga
Copy link
Member

Thanks!

@kleonc kleonc deleted the canvas-item-remove-from-canvas-group branch July 21, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:2d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Control node draws out of order if it was initially a child of type Node
2 participants
@kleonc @akien-mga