Use FlowContainer to handle toolbar overflow more gracefully
#63247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
force-pushed
the
toolbars-go-with-the-flow
branch
from
59b2a7f
to
aea5ebf
Compare
YuriSizov
force-pushed
the
toolbars-go-with-the-flow
branch
from
aea5ebf
to
dcd6479
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the agreed upon temporary solution to the toolbar overflow problem. Fixes the viewport toolbar part of #31133 (but beware, that issue also details a few other cases where an overflow can happen).
This PR can be ported to 3.x as well, since it also has a
FlowContainernow. Edit: Done #63250explorer_2022-07-20_17-01-18.mp4