EditorFileDialog: disambiguate recent/favorite items #63552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Aug 30, 2022
akien-mga
approved these changes
Aug 30, 2022
|
Might also need a rebase just in case as we've been changing core APIs a lot recently. |
|
Indeed, without the trailing slash should be perfect. |
RedMser
force-pushed
the
file-dialog-disambiguate
branch
from
438cc00
to
812ccc2
Compare
|
I did following changes:
|
|
Just found a bug when |
RedMser
force-pushed
the
file-dialog-disambiguate
branch
from
812ccc2
to
0838e8c
Compare
Similar to script editor, if two folders have the same name, they will now get a more descriptive name in the item list.
RedMser
force-pushed
the
file-dialog-disambiguate
branch
from
0838e8c
to
a401c4e
Compare
|
OK I tested everything again (both kinds of file browsers - |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of godotengine/godot-proposals#2876
Similar to the script editor, if two folders have the same name in any editor file dialog (e.g. Open Scene), they will now get a more descriptive name in the item list. Note that this is not showing the full path, it just adds the parent folder name where needed.
Also made the formatting more consistent by removing the trailing slash for both lists.