Fix backwards input in skeleton modification stack #63694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes inspector updates in set_bone_name functions since editor already gets updated before.
|
SkeletonModificationStack will be removed (replaced as node) and probably those issues will be closed with the implementation of #63588. |
4 tasks
|
Thanks for digging into it, and it's a good lesson to learn about excessive calls to Thanks for the PR submission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62876
Problem was also in SkeletonModification3DTwoBoneIK since bone_name setters work the same there. With these editor updates removed input works normal and still updates the editor values.
Related PR: #63667 (same problem)