Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Navigation Debug always enabled #63708

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Fix Navigation Debug always enabled #63708

merged 1 commit into from
Jul 31, 2022

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Jul 31, 2022

Fixes that the new Navigation Debug is always enabled in Godot debug builds.
Should only get enabled inside Editor or when "Visible Navigation" is turned on for test runs.

@smix8
Fix Navigation Debug always enabled
30c6fff 
Fixes that Navigation Debug is always enabled in debug builds even while "Visible Navigation" is turned off.
@smix8 smix8 requested a review from a team as a code owner July 31, 2022 03:48
@smix8 smix8 mentioned this pull request Jul 31, 2022
Merged
lawnjelly
lawnjelly approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make clear, this is a gotcha, confusingly DEBUG_ENABLED is set for the editor even in release builds. The Godot equivalent to a debug build is DEV_ENABLED, which is set in debug but not release_debug.

@akien-mga akien-mga added this to the 4.0 milestone Jul 31, 2022
@akien-mga akien-mga merged commit 14445c9 into godotengine:master Jul 31, 2022
@akien-mga
Copy link
Member

Thanks!

@smix8 smix8 deleted the navigation_fix_debug_always_on_4.x branch July 31, 2022 09:15
@smix8 smix8 mentioned this pull request Aug 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawnjelly lawnjelly lawnjelly approved these changes

Assignees
No one assigned
Labels
bug topic:navigation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smix8 @akien-mga @lawnjelly