FileSystemDock Fix crash when renaming a file in split mode
#64025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
added
bug
topic:editor
crash
cherrypick:3.x
akien-mga
approved these changes
Aug 7, 2022
|
Thanks! |
|
@akien-mga I wasn't sure if we still cherry-pick to |
|
Cherry-picked for 3.6. |
akien-mga
added
cherrypick:3.4
and removed
cherrypick:3.x
|
Cherry-picked for 3.5.1. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64002 which was caused by #56847.
Name of the file being renamed was obtained from the selected item in the
Treecontrol but it's not really reliable (e.g. in split mode there could be no item selected in that tree which would led to dereferencingnullptr). The proper path is already stored/available and now it's being used for checking the extension.