Rename NOTIFICATION_INSTANCED to NOTIFICATION_SCENE_INSTANTIATED

[MewPurPur]

Looks like we missed an instance of the old "instanced" verb

[YuriSizov]

Regarding keeping the terms in sync, this makes sense. But I'm not sure if this is a good name for the notification, and the description is just incorrect. Nodes don't get instantiated, packed scenes do. So there was another proposal for a rename from @QbieShay some time ago, trying to address that problem: #25538.

Maybe we should still consider a better name for this notification.

[MewPurPur]

Didn't know about this – should I edit this PR?

[YuriSizov]

You can definitely update the description of the notification to indicate that it is received when the node is at the root of a scene that was just instantiated. Basically, the reverse of what the instantiate() description tells.

As for the notification itself, probably more opinions are required. I don't have a preference. Can suggest something like NOTIFICATION_SCENE_INSTANTIATED maybe. But we can also keep it as is in this PR.

[akien-mga]

If it's received only by scene owners, then yeah SCENE_INSTANTIATED makes sense to me.

[akien-mga]

Thanks!