Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix has_filter of AnimationNode not being called in scripts #64560

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

olibombardier
Copy link

In godot 3.5, The has_filter() method was not called when implemented in a custom AnimationNode, making it impossible to have the "Edit Filter" button show up in the editor.

@olibombardier olibombardier requested a review from a team as a code owner August 18, 2022 05:49
@Calinou Calinou added this to the 3.x milestone Aug 18, 2022
@Calinou Calinou added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2022
@Calinou
Copy link
Member

Calinou commented Aug 18, 2022

Is this issue also present in 4.0.alpha? If so, please open a pull request against master too 🙂

@olibombardier
Copy link
Author

I did a bit of testing and the issue is not on the 4.0.alpha

@michael-nischt
Copy link

As pointed by @Hiiamwilliam, the binding is wrong too: (falsely returns string instead of bool)

If it's quicker to also add it to this PR for getting it the 3.5 branch, please do so.
Otherwise, I kindly ask to please merge this one instead. 🙂

@olibombardier
Copy link
Author

I didn't catch that, I fixed it here too just in case. That reminds me that the doc also says that the methds should return a string. I'll open a PR to correct that too.

@Calinou
Copy link
Member

Calinou commented Aug 21, 2022

If it's quicker to also add it to this PR for getting it the 3.5 branch, please do so.

Pull requests for the stable branch should be merged on 3.x first, as bug fixes can be cherry-picked later to 3.5. Do not open pull requests directly against the 3.5 branch.

Make sure the binding is updated as @michael-nischt described, then we can merge this in 3.x once checks have passed.

@olibombardier
Copy link
Author

Make sure the binding is updated as michael-nischt described, then we can merge this in 3.x once checks have passed.

The binding is corrected and I made sure the checks passed on my fork

@YuriSizov YuriSizov merged commit cdced05 into godotengine:3.x Aug 22, 2022
@YuriSizov
Copy link
Contributor

Seems to be indeed fixed in master with the GDVIRTUAL change. Thanks!

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Aug 22, 2022
@akien-mga
Copy link
Member

Cherry-picked for 3.5.1.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants