Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix String::word_wrap() for long words #64564

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Aug 18, 2022

3.x version of #64563

word_wrap() is used in the node configuration warning popup. This dialog is currently broken for Navigation node in simplified Chinese, because the message is a long sentence without any spaces.

ksnip_20220902-214610

It shows an unexpected newline as the first line, and the first character (open quote ) is missing.

@timothyqiu timothyqiu added bug topic:core cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Aug 18, 2022
@timothyqiu timothyqiu added this to the 3.6 milestone Aug 18, 2022
@timothyqiu timothyqiu requested review from a team as code owners August 18, 2022 09:00
@timothyqiu
Copy link
Member Author

I think this PR is ready for 3.x. (Although the master version still needs some work in order to work with TextServer.)

@akien-mga akien-mga merged commit 4769aa4 into godotengine:3.x Nov 24, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the word-wrap-3.x branch November 25, 2022 01:26
@timothyqiu
Copy link
Member Author

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants