Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose set/get_tab_button_icon() to scripting #64707

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Expose set/get_tab_button_icon() to scripting #64707

merged 1 commit into from
Aug 28, 2022

Conversation

YeldhamDev
Copy link
Member

Fixes #64498.
Supersedes #64686.

@YeldhamDev YeldhamDev added enhancement documentation topic:gui cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Aug 21, 2022
@YeldhamDev YeldhamDev added this to the 3.x milestone Aug 21, 2022
@YeldhamDev YeldhamDev requested review from a team as code owners August 21, 2022 21:16
@YeldhamDev YeldhamDev linked an issue Aug 21, 2022 that may be closed by this pull request
Tabs node's right_button_pressed signal doesn't fire #64498
Closed
@heppocogne heppocogne mentioned this pull request Aug 22, 2022
Closed
@YuriSizov
Copy link
Contributor

I know we can't rename the signal in 3.x like we did in master, but I don't like leaving it hanging like that, implying there is a left button somewhere. Would something like this be too ridiculous?

Emitted when a tab's right button is pressed. There is no left button.

@YeldhamDev
Copy link
Member Author

@YuriSizov I honestly think that the link to set_tab_button_icon() is enough.

@akien-mga akien-mga merged commit 8551d58 into godotengine:3.x Aug 28, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Aug 28, 2022
@akien-mga akien-mga mentioned this pull request Aug 28, 2022
Closed
@YeldhamDev YeldhamDev deleted the tabs_button_expose branch August 28, 2022 21:34
@akien-mga
Copy link
Member

Cherry-picked for 3.5.1.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:gui
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

Tabs node's right_button_pressed signal doesn't fire
4 participants
@YeldhamDev @YuriSizov @akien-mga @bruvzg