Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid trying to load non-existent assembly #64725

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

raulsntos
Copy link
Member

If the project assembly does not exist, return false directly instead of trying to load it.
This prevents the System.InvalidOperationException thrown for failing to locate managed application. Fixes #64723.

If the project assembly does not exist, return `false` directly instead
of trying to load it.
This prevents the `System.InvalidOperationException` thrown for failing
to locate managed application.
@raulsntos raulsntos added this to the 4.0 milestone Aug 22, 2022
@raulsntos raulsntos requested a review from a team as a code owner August 22, 2022 11:26
@neikeq neikeq merged commit ebd966a into godotengine:master Aug 23, 2022
@raulsntos raulsntos deleted the dotnet6-assembly-exists branch August 23, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dotnet InvalidOperationException error when running project converter
2 participants