workaround for angle project issue 7245, safari, iOS #64811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivers/gles3/shaders/particles.glsl
Outdated
| @@ -211,7 +211,7 @@ VERTEX_SHADER_CODE | |||
|
|
|||
| xform = transpose(xform); | |||
|
|
|||
| out_velocity_active.a = mix(0.0, 1.0, shader_active); | |||
| out_velocity_active.a = mix(0.0, 1.0, float(shader_active)); | |||
There was a problem hiding this comment.
Maybe just out_velocity_active.a = float(shader_active);?
Calinou
added
bug
platform:web
platform:ios
topic:rendering
topic:porting
cherrypick:3.5
jordo
force-pushed
the
fix/safari-particles-fix
branch
from
156a26d
to
1ed1a30
Compare
RandomShaper
approved these changes
Aug 24, 2022
|
Thanks! |
|
Cherry-picked for 3.5.1. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for an angle limitation on safari on iOS, and Macos (confirmed on both host platforms).
This fix makes particles render properly on safari.
Works around this reported angle issue (also seems like a problem on angle's vulkan backend).