Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document MultiMesh members #65491

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

MJacred
Copy link
Contributor

@MJacred MJacred commented Sep 7, 2022

now all members are described, except for buffer, because there are 2 MeshStorage::multimesh_set_buffer (one for gles3 and the other Vulkan, I reckon). Former respects e.g. custom color and data, while the latter is only concerned with data cache and aabb… Not sure how to describe this in any useful and concise way

Note: blend shape info comes from #15778 (comment)

Fixes #44912, if it's only left open for documentation purposes (handled in 2nd commit in this PR)

@MJacred MJacred requested a review from a team as a code owner September 7, 2022 18:53
@Chaosus Chaosus added this to the 4.0 milestone Sep 7, 2022
@MJacred MJacred force-pushed the docs/multimesh branch 3 times, most recently from ab53e95 to 7a1f258 Compare September 7, 2022 19:54
doc/classes/MultiMesh.xml Outdated Show resolved Hide resolved
doc/classes/MultiMesh.xml Outdated Show resolved Hide resolved
doc/classes/MultiMesh.xml Outdated Show resolved Hide resolved
doc/classes/MultiMesh.xml Outdated Show resolved Hide resolved
doc/classes/MultiMesh.xml Outdated Show resolved Hide resolved
@MJacred MJacred requested review from YuriSizov and removed request for clayjohn September 8, 2022 12:48
@akien-mga akien-mga merged commit 6c352c1 into godotengine:master Sep 14, 2022
@akien-mga
Copy link
Member

Thanks!

@MJacred MJacred deleted the docs/multimesh branch September 15, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants