Fix cyclic references issues with global classes #65664
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works in tandem with #65752 for fixing cyclic references issues.This PR is not needed if #65752 is merged, as it deals too with global classes.
This makes possible to reference class
A
(class_name A
) in classB
(class_name B
) andB
inA
. This is not possible actually.In the master branch, this code fails on runtime with this error:
Parser Error: Can't load global class B, cyclic reference?
The compiler, in this PR, checks if the script of the global class can be loaded. When the script exists but cannot be loaded, it means usually that the script is loaded but not compiled. So, the compiler now tags this entity as temporary to be read dynamically instead of being considered as a constant.
Minimal reproduction project:
cyclic2.zip
Fixes #21461, fixes #41027.