Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent drawing MultiMesh with zero instance count #65826

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Sep 15, 2022

Issuing a driver drawcall for MultiMesh with zero instances crashes some drivers.

Instead we just early out from any drawing code for these items.
Fixes GLES2 and GLES3 for both 2D and 3D.

Fixes #65795

Issuing a driver drawcall for MultiMesh with zero instances crashes some drivers.
@lawnjelly lawnjelly requested a review from a team as a code owner September 15, 2022 12:23
@lawnjelly lawnjelly added bug topic:rendering crash cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Sep 15, 2022
@lawnjelly lawnjelly added this to the 3.6 milestone Sep 15, 2022
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.1.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants