Delete set_all, set_axis, and get_axis methods from Vector2/3/3i/4/4i
#66133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
changed the title
set_all, set_axis, and get_axis methods from Vector2/2i/3/3i/4/4iset_all, set_axis, and get_axis methods from Vector2/3/3i/4/4i
aaronfranke
changed the title
set_all, set_axis, and get_axis methods from Vector2/3/3i/4/4iset_all, set_axis, and get_axis methods from Vector2/3/3i/4/4i
Can all language bindings use the C++ array operators? How does it work in GDExtension? |
|
GDScript can use the array operator. C# and GDExtension C++ each have the vector types implemented natively in their language with array operators of their own. I don't know how it works for non-C++ GDExtension. |
akien-mga
approved these changes
Oct 1, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_allis not a very useful method, it was only used in one place in BVH. However, the rest of the BVH code just iterates over the axis count, so this PR changes theset_allcode to use this approach and removesset_all. Also,set_allwas broken in Vector4, which is what got me investigating this method in the first place.I deleted the
set_axisandget_axismethods because they are not used internally anywhere (except for the tests) and they do the same thing as the array operator anyway. Also, Vector2i did not have it.