Commits on Sep 23, 2022

1. SCons: Cleanup DEBUG, _DEBUG and NDEBUG defines …

   - `_DEBUG` is MSVC specific so it didn't make much sense to define for
     Android and iOS builds.
   - iOS was the only platform to define `DEBUG`. We don't use it anywhere
     outside thirdparty code, which we usually don't intend to debug, so it
     seems better to be consistent with other platforms.
   - Consistently define `NDEBUG` to disable assert behavior in both `release`
     and `release_debug` targets. This used to be set for `release` for all
     platforms, and `release_debug` for Android and iOS only.
   - Due to the above, I removed the only use we made of `assert()` in Godot
     code, which was only implemented for Unix anyway, should have been
     `DEV_ENABLED`, and is in PoolAllocator which we don't actually use.
   - The denoise and recast modules keep defining `NDEBUG` even for the `debug`
     target as we don't want OIDN and Embree asserting all over the place.

   

   akien-mga committed Sep 23, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 26e9145
   • Browse repository at this point

   Copy the full SHA

   26e9145 View commit details

   Browse the repository at this point in the history