Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debanding strength being affected by environment adjustments (3.x) #66327

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 23, 2022

3.x version of #66317.

Testing project: test_debanding_adjustments_3.x.zip

Preview

Click to view at full size.

No adjustments

Before After
2022-09-24_00 00 39 2022-09-24_00 01 50

With adjustments (Brightness = 2.75, Contrast = 8.0)

Before After
2022-09-24_00 01 10 2022-09-24_00 01 42

No adjustments, with ACES Fitted tonemap (Exposure = 4.0, White = 16.0)

Before After
2022-09-24_00 02 22 2022-09-24_00 02 35

@Calinou Calinou requested a review from a team as a code owner September 23, 2022 22:05
@Calinou Calinou added bug topic:rendering cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Sep 23, 2022
@Calinou Calinou added this to the 3.6 milestone Sep 23, 2022
@Calinou Calinou changed the title Fix debanding strength being affected by environment adjustments Fix debanding strength being affected by environment adjustments (3.x) Sep 23, 2022
@Calinou Calinou force-pushed the debanding-fix-adjustments-3.x branch from b43692e to 6d0d903 Compare September 26, 2022 12:46
@akien-mga akien-mga merged commit faade5f into godotengine:3.x Sep 27, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the debanding-fix-adjustments-3.x branch September 27, 2022 15:08
@timothyqiu
Copy link
Member

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants