-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize some code to have 2D things grouped together #66744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR review meeting: further internal cleanup may be nice, but not priority for now in 4.0 Beta phase. |
aaronfranke
force-pushed
the
group-2d
branch
2 times, most recently
from
November 24, 2022 20:04
f68139c
to
92b149f
Compare
aaronfranke
force-pushed
the
group-2d
branch
from
December 20, 2022 02:41
92b149f
to
77a3461
Compare
aaronfranke
force-pushed
the
group-2d
branch
2 times, most recently
from
February 1, 2023 21:57
06de765
to
cffb88e
Compare
aaronfranke
force-pushed
the
group-2d
branch
2 times, most recently
from
February 3, 2023 17:16
86586d2
to
c275453
Compare
aaronfranke
force-pushed
the
group-2d
branch
from
February 11, 2023 06:57
c275453
to
c88bdec
Compare
aaronfranke
force-pushed
the
group-2d
branch
from
February 20, 2023 22:35
c88bdec
to
4e97126
Compare
aaronfranke
force-pushed
the
group-2d
branch
from
September 23, 2023 21:24
084400e
to
ed48e60
Compare
aaronfranke
force-pushed
the
group-2d
branch
from
December 24, 2023 21:39
cbb8880
to
b352e16
Compare
aaronfranke
force-pushed
the
group-2d
branch
2 times, most recently
from
March 13, 2024 19:34
1239af8
to
4a0ef1b
Compare
aaronfranke
force-pushed
the
group-2d
branch
2 times, most recently
from
March 27, 2024 03:07
0d18684
to
795d7b0
Compare
akien-mga
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine overall.
AThousandShips
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes pieces out of #47054, in the same vain as how #51474 took pieces out of #50147.
skeleton_menu
declaration next to the rest of the skeleton code.Control
-derived options beforeNode2D
-derived ones.