Fix Editor crash when MeshLibrary gets replaced while used in an open Scene #67141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkKilauea
reviewed
Oct 9, 2022
akien-mga
added
the
cherrypick:3.5
akien-mga
approved these changes
Oct 14, 2022
|
Thanks! |
|
Cherry-picked for 3.5.2 |
timothyqiu
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64393
Some functions are intended to be called inside the SceneTree so get_global_transform() and get_world() can work but this is not always the case when the scene is loaded in e.g. an Editor background tab. The MeshLibrary replacement is triggering a lot of them and while transform fails only polluted the error log the call to get_world() was a fatal error that crashed the Editor.
In Godot 4.x this is already guarded / handled slightly differently.