Expose all existing PropertyHint global enums #67360
Conversation
|
I am not confident on this, but one of the checks may soon fail because there's no documentation defined for these in |
I can add the documentation if required. I'm assuming whats on master is applicable here as well. |
jordo
force-pushed
the
PR-expose-property-hints
branch
from
8a6c8d9
to
8e9e21f
Compare
|
Added documentation. Matches what's currently in |
| BIND_GLOBAL_ENUM_CONSTANT(PROPERTY_HINT_PROPERTY_OF_SCRIPT); | ||
| BIND_GLOBAL_ENUM_CONSTANT(PROPERTY_HINT_OBJECT_TOO_BIG); | ||
| BIND_GLOBAL_ENUM_CONSTANT(PROPERTY_HINT_NODE_PATH_VALID_TYPES); | ||
| BIND_GLOBAL_ENUM_CONSTANT(PROPERTY_HINT_SAVE_FILE); |
There was a problem hiding this comment.
Missing PROPERTY_HINT_ENUM_SUGGESTION.
There was a problem hiding this comment.
And the docs check will likely still fail as PROPERTY_HINT_MAX is bound but not documented.
The best is to run --doctool to generate the template from your compiled binary.
There was a problem hiding this comment.
Missing
PROPERTY_HINT_ENUM_SUGGESTION.
Not missed it's just included in a different place from @YuriSizov.
If you like I can move this around in @GlobalScope.xml to re-organize, or just leave it as is.
There was a problem hiding this comment.
Ah I see. I guess it was put there because ENUM and ENUM_SUGGESTION are linked, but were not made consecutive in the enum to avoid breaking compat. Can probably be kept as is.
akien-mga
added
enhancement
topic:core
cherrypick:3.5
jordo
force-pushed
the
PR-expose-property-hints
branch
from
8e9e21f
to
dc5226e
Compare
|
Thanks! |
|
Cherry-picked for 3.5.2. |
akien-mga
removed
the
cherrypick:3.5
akien-mga
changed the title
As disucssed on RC, exposes additional global enums in 3.x that have been exposed in
master. Allows for elimination of using magic numbers for these.