Fix typed array export

[GuilhermeGSousa]

Fixes #62916.

Also confirmed that this works nicely together with #67055 to get exported arrays of custom node types.

[GuilhermeGSousa]

I'm closing this for now as this PR isn't really ready yet, there are still some issues on runtime. I'll reopen it once its ready

[GuilhermeGSousa]

Some known issues to fix before undrafting this:

• Exported arrays are not being saved correctly
• Exported typed arrays dont work for custom Resources, although that is outside of the scope of the issue this PR is trying to fix, and would probably deserve its own issue/PR

[GuilhermeGSousa]

@Paulb23 @YeldhamDev could I get a review for this one?

[DmitriySalnikov]

I didn't know about this PR and tried to fix the problem myself, my code is below. Here I just cut off metadata/_editor_prop_ptr_ if there is one (I don't know which option would be preferable 🤷‍♂️)

diff --git a/editor/editor_properties_array_dict.cpp b/editor/editor_properties_array_dict.cpp
index 451cb7cfee..606fc8239b 100644
--- a/editor/editor_properties_array_dict.cpp
+++ b/editor/editor_properties_array_dict.cpp
@@ -36,9 +36,10 @@
 #include "editor/editor_scale.h"
 #include "editor/editor_settings.h"
 #include "editor/inspector_dock.h"
+#include "scene/resources/packed_scene.h"
 
 bool EditorPropertyArrayObject::_set(const StringName &p_name, const Variant &p_value) {
-	String name = p_name;
+	String name = String(p_name).replace(SceneState::get_meta_pointer_property(""), "");
 
 	if (name.begins_with("indices")) {
 		int index = name.get_slicec('/', 1).to_int();
@@ -50,7 +51,7 @@ bool EditorPropertyArrayObject::_set(const StringName &p_name, const Variant &p_
 }
 
 bool EditorPropertyArrayObject::_get(const StringName &p_name, Variant &r_ret) const {
-	String name = p_name;
+	String name = String(p_name).replace(SceneState::get_meta_pointer_property(""), "");
 
 	if (name.begins_with("indices")) {
 		int index = name.get_slicec('/', 1).to_int();
@@ -159,8 +160,9 @@ EditorPropertyDictionaryObject::EditorPropertyDictionaryObject() {
 ///////////////////// ARRAY ///////////////////////////
 
 void EditorPropertyArray::_property_changed(const String &p_property, Variant p_value, const String &p_name, bool p_changing) {
-	if (p_property.begins_with("indices")) {
-		int index = p_property.get_slice("/", 1).to_int();
+	String name = p_property.replace(SceneState::get_meta_pointer_property(""), "");
+	if (name.begins_with("indices")) {
+		int index = name.get_slice("/", 1).to_int();
 		Variant array = object->get_array();
 		array.set(index, p_value);
 		emit_changed(get_edited_property(), array, "", true);

My changes and your changes for PackedScene work correctly (I couldn't apply all your changes via git apply). But only without @tool mode. With the @tool mode active, several errors appear when opening the scene and the array becomes null. Is this expected?

[lejar]

Hi, is there anything I can do to help move this along? I'd like to use this feature in a project.

[GuilhermeGSousa]

@lejar I just pushed @KoBeWi 's change request. I don't currently have my godot dev environment setup so I can't currently work on this PR, but everything should be here to fix the issue, its only missing a review.

[KoBeWi]

Needs rebase. Also this doesn't seem to work anymore, probably after TypedArray changes.

Attempted to set a variable of type 'NodePath' into a TypedArray of type 'Object'.
core\variant\array.cpp:410 - Condition "!_p->typed.validate(value, "set")" is true.

[KoBeWi]

Avoid converting StringName to String more than once. Do

String string_property = dnp.property;

[KoBeWi]

Suggested change

	StringName prop_name = snames[name_idx];
	const StringName &prop_name = snames[name_idx];

(technically applies to other variables too)

[GuilhermeGSousa]

Thanks @KoBeWi I'll check this out

[dannflor]

@GuilhermeGSousa are you still working on this? It's a pretty bad blocker for me and I'd like to see it merged sooner than later.

[GuilhermeGSousa]

Closing this in favor of #73256