-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PROPERTY_HINT_IMAGE_COMPRESS
constants
#67688
The head ref may contain hidden characters: "i-forgror-\u2620\uFE0F\u2620\uFE0F"
Conversation
What about lossy-compressed webps? Textures can still be encoded as those. |
This comment was marked as outdated.
This comment was marked as outdated.
Don't worry, these are not import options. I reiterate, these property hints do not do anything in the engine. |
This comment was marked as outdated.
This comment was marked as outdated.
This PR's failing check has made me discover that PROPERTY_HINT_INT_IS_POINTER and PROPERTY_HINT_ARRAY_TYPE are exposed in the wrong order and should be swapped. Putting it out here as a mental note. |
ef5ad2c
to
bb2b13f
Compare
I am sorry, I had thought that this also removed |
After some searching through the code, I don't see any Object that encodes PropertyHint directly into a resource. I don't think this will break any Godot resources; it might break resources in extensions that do that, though. It might also break third-party editor tools that rely on the PropertyHint enum they get from the language server directly. In either case, the enum values started changing back in April, here: #60458 At the time, It was decided to just merge and cleanup later. So I guess that's something to worry about later? 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in PR review meeting, those are unused (also unused in 3.x but we don't want to break compat there).
These were used in 3.x but there's no reference of them in the codebase, at all.
bb2b13f
to
b4324e7
Compare
Rebased. |
Thanks! |
Removes PROPERTY_HINT_IMAGE_COMPRESS_LOSSY and PROPERTY_HINT_IMAGE_COMPRESS_LOSSLESS. These do not actually do anything, at all. These were used in 3.x, but are no longer necessary now.