Identify debug instances with window title #68054
Open
+48
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2022-10-30.21-42-11.mp4 |
kdada
force-pushed
the
identify-debug-instances
branch
from
d45709b to
1590d99
Compare
bruvzg
approved these changes
Oct 31, 2022
kdada
force-pushed
the
identify-debug-instances
branch
from
1590d99 to
9d0b9c5
Compare
|
Fixed conflict |
|
Does this impact only running multiple instances, or would it also show "Session 1" when running a single instance? (I think the former is better.) |
Even though there is an instance, it still shows "Session 1" in the title. If an instance needs to hide "Session 1", it must receive a "signal" to identify its specificity. e.g. Add a cmd arg like "--debug-singleton". I find this a little weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3357, #64913
This PR passes session id via debug message instead of cmd args. It is always correct even if the debug instances are not connected to debug server in order.