Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emit target_reached signal after updating state #68072

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix: emit target_reached signal after updating state #68072

merged 1 commit into from
Oct 31, 2022

Conversation

sambriels
Copy link
Contributor

Backport to 3.x for the fix in #67939, as discussed in that PR

@sambriels sambriels requested a review from a team as a code owner October 31, 2022 07:19
@timothyqiu timothyqiu added this to the 3.6 milestone Oct 31, 2022
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Oct 31, 2022
@akien-mga
Copy link
Member

Needs rebase to fix iOS build issue (since fixed in 3.x).

@sambriels sambriels force-pushed the backport-of-pull-request-67939 branch from ab2da3f to 3e186ae Compare October 31, 2022 12:04
@sambriels
Copy link
Contributor Author

✅ @akien-mga

@akien-mga akien-mga merged commit 9f4d767 into godotengine:3.x Oct 31, 2022
@akien-mga
Copy link
Member

Thanks!

@sambriels sambriels deleted the backport-of-pull-request-67939 branch October 31, 2022 14:48
@timothyqiu
Copy link
Member

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:navigation
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@sambriels @akien-mga @timothyqiu