Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast dragged file name extension to lowercase #68107

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Cast dragged file name extension to lowercase #68107

merged 1 commit into from
Nov 2, 2022

Conversation

alfredbaudisch
Copy link
Contributor

Fixes and closes #68104

@alfredbaudisch alfredbaudisch mentioned this pull request Nov 1, 2022
Closed
@alfredbaudisch alfredbaudisch changed the title Cast dragged file extension name to lowercase, closes #68104 Cast dragged file name extension to lowercase, closes #68104 Nov 1, 2022
@alfredbaudisch alfredbaudisch changed the title Cast dragged file name extension to lowercase, closes #68104 Cast dragged file name extension to lowercase Nov 1, 2022
@Chaosus Chaosus added this to the 4.0 milestone Nov 1, 2022
@akien-mga
Copy link
Member

Looks good. There's the same bug in editor/plugins/node_3d_editor_plugin.cpp which would be good to fix at the same time.

@alfredbaudisch alfredbaudisch requested a review from a team as a code owner November 1, 2022 08:48
@alfredbaudisch
Copy link
Contributor Author

editor/plugins/node_3d_editor_plugin.cpp

Pushed. And also editor\editor_node.cpp.

@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Nov 1, 2022
@akien-mga akien-mga merged commit 50f742e into godotengine:master Nov 2, 2022
@akien-mga
Copy link
Member

Thanks!

@alfredbaudisch alfredbaudisch deleted the drag-lower-case branch November 8, 2022 12:29
@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 30, 2022
@timothyqiu
Copy link
Member

Cherry-picked for 3.5.2

@timothyqiu timothyqiu removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Drag and drop picture editor can't recognize JPG in uppercase
4 participants
@alfredbaudisch @akien-mga @timothyqiu @Chaosus