Correctly compute inverse_mass when inertia is defined by the user #68659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rburing
approved these changes
Nov 14, 2022
akien-mga
added
bug
topic:physics
topic:2d
cherrypick:3.5
|
I checked if this was applicable to 3D and/or 4.0 but those don't seem to have an early |
|
Thanks! |
|
Cherry-picked for 3.5.2 |
timothyqiu
removed
the
cherrypick:3.5
|
In 3.5.2 I can still run into something like this if the mass and inertia are set before the body is inserted into the tree. Once it is added to the tree the body acts like mass = 1. If you then set inertia to zero then reset inertia to the desired value the mass behaves as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68655
An early
breakprevented the code reaching the inverse_mass calculation