Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unregister for GLTFDocumentExtension #69022

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

RedMser
Copy link
Contributor

@RedMser RedMser commented Nov 22, 2022

When using GLTFDocumentExtension in a tool script, you will need to unregister it when the plugin is disabled.

Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @aaronfranke Any thoughts?

@akien-mga akien-mga merged commit 608d266 into godotengine:master Nov 23, 2022
@akien-mga
Copy link
Member

Thanks!

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants