Print warning when custom class icon size exceeds 32x32, update docs mentioning recommended size #69074
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souplamp
force-pushed
the
big-icon-warning
branch
from
a65ada9
to
b388f04
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Calinou
reviewed
Dec 1, 2022
Calinou
reviewed
Dec 1, 2022
Calinou
reviewed
Dec 1, 2022
souplamp
force-pushed
the
big-icon-warning
branch
from
387f035
to
3bc0028
Compare
Warn user of `@icon` sizes larger than 32x32. This resolution is good for hiDPI displays; higher resolutions effect performance. Make mention of this in the docs as well.
souplamp
force-pushed
the
big-icon-warning
branch
from
3bc0028
to
873bb30
Compare
|
Edit: Not sure why I said that it would be impossible, as we can get the size of the loaded texture. However, there is no reason to throw a warning after #75472, as we would handle this gracefully throughout the editor. So I still think we should reduce this PR to the documentation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #68962 (comment).
Prints a warning when a custom class icon is greater than the recommended size of 32x32. Also updates the docs to mention that 32x32 is the recommended size as it looks good on hiDPI displays.
Ex.
