Fix Screen-Transform missing in Button Size in OptionButton::show_popup #69185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-optionpopup-screentransform
branch
from
8e370cc to
dc091ba
Compare
The button size is affected by the screen transform, which was previously not taken into consideration.
Sauermann
force-pushed
the
fix-optionpopup-screentransform
branch
from
dc091ba to
084a4ad
Compare
akien-mga
approved these changes
Feb 6, 2023
|
How should I handle the bugsquad edit in the OP? |
|
Feel free to edit the message if you know the issue will not be fully fixed. |
|
Thanks for the info, have removed the link. I just wanted to make sure, that there are no reasons for the edit, that I am not aware of. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button size is affected by the screen transform, which was previously not taken into consideration.
This resulted in the following situation for an
OptionButtonwithin aSubViewportContainer.When the
SubViewportContainerhad a non-identity-transform (like a scale of 2 in the picture), the PopupMenu was positioned without including the scale for its position:fix part of #69171 (PopupMenu appears at wrong position)
follow up to #68573
Updated 2023-02-06: Rebase to master in order to include dependencies