Update Recast integration to fix crash in NavigationMesh baking #69189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been targeted for 4x but can be backported to 3x safely as well. |
This was referenced Nov 26, 2022
Closed
akien-mga
added
bug
topic:thirdparty
cherrypick:3.x
|
Looks great, thanks! Could you also update |
In some cases Godot can generate input parameters to Recast that cause it to crash. Specifically when baking NavigationMeshes for input meshes that have axis extents less than half the NavigationMesh CellSize. This has been fixed upstream in Recast (in recastnavigation/recastnavigation@3901c58). Updating Godot's Recast integration fixes this crash issue in Godot as well.
grahamboree
force-pushed
the
updated-recast
branch
from
60a37f4
to
36de150
Compare
|
README.md updated. I amended the original commit so there's just the 1 commit to merge. Thanks! |
akien-mga
approved these changes
Nov 28, 2022
|
Thanks! And congrats for your first merged Godot contribution 🎉 Edit: Well this was my stock welcome message - obviously as part of the Recast team you already had a lot of code contributions merged in Godot :P |
|
Hahah thanks! I suppose I have contributed to a lot of games and engines then if that counts ;P |
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.2 |
timothyqiu
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases Godot can generate input parameters to Recast that cause it to crash. Specifically when baking NavigationMeshes for input meshes that have axis extents less than half the NavigationMesh CellSize.
This has been fixed upstream in Recast (in recastnavigation/recastnavigation@3901c58). Updating Godot's Recast integration fixes this crash issue in Godot as well.
Fixes #65764